Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MpscFFLamportOffHeapFixedSizeRingBuffer or MpscOffHeapFixedSizeRingBuffer? #219

Open
franz1981 opened this issue Sep 12, 2018 · 0 comments

Comments

@franz1981
Copy link
Collaborator

franz1981 commented Sep 12, 2018

ATM both MPSC channels implementations are provided into jctools-channels, but the MpscFFLamportOffHeapFixedSizeRingBuffer::readAcquire is implemented in a more "conservative" (and slower) way, given that is behaving like Queue::poll ie return null iff empty.
It would be better to maintain just one of the 2 implementations: I'm personally biased toward MpscFFLamportOffHeapFixedSizeRingBuffer (I have implemented it :P), but "there can be only one", hopefully the fastest IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants