Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #216: Size of SpscGrowableArrayQueue can exceeds max capacity #218

Merged
merged 1 commit into from Sep 20, 2018

Conversation

franz1981
Copy link
Collaborator

Adjust producer limit in order to allow one more element to be added
in place of the unneeded JUMP when the max capacity producer buffer
has been allocated

@franz1981 franz1981 changed the title Fixes #28: Size of SpscGrowableArrayQueue can exceeds max capacity fixes #28: Size of SpscGrowableArrayQueue can exceeds max capacity Sep 7, 2018
@franz1981 franz1981 changed the title fixes #28: Size of SpscGrowableArrayQueue can exceeds max capacity Fixes #216: Size of SpscGrowableArrayQueue can exceeds max capacity Sep 7, 2018
@coveralls
Copy link

coveralls commented Sep 7, 2018

Pull Request Test Coverage Report for Build 446

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 69.204%

Files with Coverage Reduction New Missed Lines %
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMap.java 1 81.62%
jctools-core/src/main/java/org/jctools/queues/atomic/SpscGrowableAtomicArrayQueue.java 1 93.55%
jctools-core/src/main/java/org/jctools/maps/NonBlockingSetInt.java 3 77.65%
Totals Coverage Status
Change from base Build 443: 0.2%
Covered Lines: 5672
Relevant Lines: 8196

💛 - Coveralls

@franz1981
Copy link
Collaborator Author

franz1981 commented Sep 7, 2018

@nitsanw I can add a test similar to the one provided by @yangyi438 if necessary, but I have already verified that it fixes the referenced issue :)
Sorry for the multiple changes of commit msg/PR name, but I was experimenting to reference the issue number into the commit msg to allow github to ref & close them in tandem :P

@nitsanw
Copy link
Contributor

nitsanw commented Sep 8, 2018

Please add the test.
Thanks for jumping in :-)

…acity

Adjust producer limit in order to allow one more element to be added
in place of the unneeded JUMP when the max capacity producer buffer
has been allocated
@franz1981
Copy link
Collaborator Author

@nitsanw No worries :)
I admit is not one of my most brilliant tests, but let me know if is enough 👍

@nitsanw nitsanw merged commit 19b10c8 into JCTools:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants