Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reason why the MpscLinkedAtomicQueue class is final? #208

Closed
voidburn opened this issue Mar 9, 2018 · 2 comments
Closed

Reason why the MpscLinkedAtomicQueue class is final? #208

voidburn opened this issue Mar 9, 2018 · 2 comments

Comments

@voidburn
Copy link

voidburn commented Mar 9, 2018

I'm implementing time sliced self processing queues, and this is the only instance of the backing queue for which I need to wrap instead of extending the class. I'm fine with methods being final, but I cannot understand why the class itself cannot be extended in this specific case?
@nitsanw nitsanw closed this as completed in dab43bc Mar 9, 2018
@nitsanw
Copy link
Contributor

nitsanw commented Mar 9, 2018

Thanks for reporting!

@voidburn
Copy link
Author

voidburn commented Mar 1, 2019

FYI: This regressed after the fix and made it back into 2.1.2, still can't extend.

franz1981 added a commit to franz1981/JCTools that referenced this issue Mar 1, 2019
@franz1981
Fixes JCTools#208: MpscLinkedAtomicQueue can be made not final
e7101bf
kay added a commit that referenced this issue Mar 3, 2019
@kay
Merge pull request #231 from franz1981/not_final_mpsc_linked_atomic_q
23432e5 
Fixes #208: MpscLinkedAtomicQueue can be made not final
kay added a commit to kay/JCTools that referenced this issue Mar 3, 2019
@kay
Don't mark generated linked atomic queues as final
0029a28 
Reported in JCTools#208, fixed but subsequent regressed as fix edited generated
source. This change should fix it permanently.
kay added a commit to kay/JCTools that referenced this issue Mar 3, 2019
@kay
Don't mark generated linked atomic queues as final
9db418c 
Reported in JCTools#208, fixed but subsequent regressed as fix edited generated
source. This change should fix it permanently.
@kay kay mentioned this issue Mar 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voidburn @nitsanw