From 257f9ef6f18597151701c95ea8533ed458f662ff Mon Sep 17 00:00:00 2001 From: Ivan Goncharov Date: Mon, 26 Aug 2019 18:12:05 +0300 Subject: [PATCH] GraphQLArgument: make 'description' undefined by default (#2132) --- src/type/__tests__/definition-test.js | 2 +- src/type/__tests__/directive-test.js | 4 ++-- src/type/definition.js | 2 +- src/type/directives.js | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/type/__tests__/definition-test.js b/src/type/__tests__/definition-test.js index 77cee03a0f..f66ca60b87 100644 --- a/src/type/__tests__/definition-test.js +++ b/src/type/__tests__/definition-test.js @@ -243,7 +243,7 @@ describe('Type System: Objects', () => { args: [ { name: 'arg', - description: null, + description: undefined, type: ScalarType, defaultValue: undefined, extensions: undefined, diff --git a/src/type/__tests__/directive-test.js b/src/type/__tests__/directive-test.js index 640b236613..38bbe852a9 100644 --- a/src/type/__tests__/directive-test.js +++ b/src/type/__tests__/directive-test.js @@ -36,7 +36,7 @@ describe('Type System: Directive', () => { args: [ { name: 'foo', - description: null, + description: undefined, type: GraphQLString, defaultValue: undefined, extensions: undefined, @@ -44,7 +44,7 @@ describe('Type System: Directive', () => { }, { name: 'bar', - description: null, + description: undefined, type: GraphQLInt, defaultValue: undefined, extensions: undefined, diff --git a/src/type/definition.js b/src/type/definition.js index 3fe9920246..6986783723 100644 --- a/src/type/definition.js +++ b/src/type/definition.js @@ -783,7 +783,7 @@ function defineFieldMap( const args = objectEntries(argsConfig).map(([argName, arg]) => ({ name: argName, - description: arg.description === undefined ? null : arg.description, + description: arg.description, type: arg.type, defaultValue: arg.defaultValue, extensions: arg.extensions && toObjMap(arg.extensions), diff --git a/src/type/directives.js b/src/type/directives.js index 0d2071d5a1..2a8a119b52 100644 --- a/src/type/directives.js +++ b/src/type/directives.js @@ -83,7 +83,7 @@ export class GraphQLDirective { this.args = objectEntries(args).map(([argName, arg]) => ({ name: argName, - description: arg.description === undefined ? null : arg.description, + description: arg.description, type: arg.type, defaultValue: arg.defaultValue, extensions: arg.extensions && toObjMap(arg.extensions),