From 9b5cc65f36bd6b69629e42c445317ea6d4706ecf Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 11:25:14 -0800 Subject: [PATCH 01/20] Add daily test job --- .github/workflows/daily.yaml | 31 ++++++++++++++++++++++ .github/workflows/security-audit.yaml | 37 --------------------------- 2 files changed, 31 insertions(+), 37 deletions(-) create mode 100644 .github/workflows/daily.yaml delete mode 100644 .github/workflows/security-audit.yaml diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml new file mode 100644 index 00000000..63579c0c --- /dev/null +++ b/.github/workflows/daily.yaml @@ -0,0 +1,31 @@ +name: Daily runs + +# Run daily and also when Cargo.toml changes +on: + schedule: + - cron: "0 8 * * *" # 8AM UTC + push: + paths: + - "**/Cargo.toml" + workflow_dispatch: + +jobs: + security-audit: + runs-on: ubuntu-18.04 + steps: + - uses: actions/checkout@v2 + - name: Run audit checker + uses: actions-rs/audit-check@v1 + with: + token: ${{ secrets.GITHUB_TOKEN }} + + test: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - run: cargo test --all-features + - name: Post to Slack + if: always() + run: | + curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ + -F 'payload="{\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}"' diff --git a/.github/workflows/security-audit.yaml b/.github/workflows/security-audit.yaml deleted file mode 100644 index d88b0a9f..00000000 --- a/.github/workflows/security-audit.yaml +++ /dev/null @@ -1,37 +0,0 @@ -name: Security Audit - -# Run daily and also when Cargo.toml changes -on: - schedule: - - cron: "0 8 * * *" # 8AM UTC, 3PM MST - push: - paths: - - "**/Cargo.toml" - -jobs: - security-audit: - runs-on: ubuntu-18.04 - steps: - - uses: actions/checkout@v2 - - name: Install Rust - uses: actions-rs/toolchain@v1 - with: - profile: minimal - toolchain: stable - override: true - - name: Search for cargo-audit to get latest version - id: audit-search - run: echo ::set-output name=audit-version::$(cargo search cargo-audit --limit 1 | grep cargo-audit) - - name: Restore cargo-audit based on search result - id: cache - uses: actions/cache@v2 - with: - path: ~/.cargo/bin - key: ${{ github.workflow }} ${{ steps.audit-search.outputs.audit-version }} - - name: Install cargo-audit if the cache missed - run: cargo install cargo-audit - if: steps.cache.outputs.cache-hit != 'true' - - name: Run audit checker - uses: actions-rs/audit-check@v1 - with: - token: ${{ secrets.GITHUB_TOKEN }} From 2c1371306b71292fc2c67f328a68bca25ff1faab Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 11:28:06 -0800 Subject: [PATCH 02/20] On push to this branch --- .github/workflows/daily.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 63579c0c..554bf5ed 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -5,6 +5,7 @@ on: schedule: - cron: "0 8 * * *" # 8AM UTC push: + branches: daily-test-hack-day paths: - "**/Cargo.toml" workflow_dispatch: From 21024b887983960b293563eb478c1556de7f9df2 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 11:28:53 -0800 Subject: [PATCH 03/20] maybe? --- .github/workflows/daily.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 554bf5ed..213c40f8 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -5,9 +5,10 @@ on: schedule: - cron: "0 8 * * *" # 8AM UTC push: - branches: daily-test-hack-day - paths: - - "**/Cargo.toml" + branches: + - daily-test-hack-day + # paths: + # - "**/Cargo.toml" workflow_dispatch: jobs: From 3538584fd22766f8cbda7f2f7c1b2423b3dbac3f Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 11:59:23 -0800 Subject: [PATCH 04/20] Try other method of outputting env vars --- .github/workflows/daily.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 213c40f8..c4db40ef 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -25,9 +25,12 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - run: cargo test --all-features + - name: Decrypt test keys + run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem + # - run: cargo test --all-features + - run: exit 1 - name: Post to Slack - if: always() + if: failure() run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ - -F 'payload="{\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}"' + -F 'payload="{\"text\": \"Failed a run of <${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}|${GITHUB_REPOSITORY}>.\"}"' From 89909114f709ccce6db8ddcba955cb7444bfd173 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 12:15:45 -0800 Subject: [PATCH 05/20] Try again --- .github/workflows/daily.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index c4db40ef..a0794884 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -33,4 +33,4 @@ jobs: if: failure() run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ - -F 'payload="{\"text\": \"Failed a run of <${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}|${GITHUB_REPOSITORY}>.\"}"' + -F 'payload="{\"text\": \"Failed a run of <${{env.GITHUB_SERVER_URL}}/${{env.GITHUB_REPOSITORY}}/actions/runs/${{env.GITHUB_RUN_ID}}|${{env.GITHUB_REPOSITORY}}>.\"}"' From aa3fafa835fc5c197b3cf874d9ba77786b9fa28d Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 12:25:30 -0800 Subject: [PATCH 06/20] It'll work this time --- .github/workflows/daily.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index a0794884..ced92918 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -33,4 +33,4 @@ jobs: if: failure() run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ - -F 'payload="{\"text\": \"Failed a run of <${{env.GITHUB_SERVER_URL}}/${{env.GITHUB_REPOSITORY}}/actions/runs/${{env.GITHUB_RUN_ID}}|${{env.GITHUB_REPOSITORY}}>.\"}"' + -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" From 58b05d690c16d9d5276d9abafd433b36ff3d7602 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 12:31:47 -0800 Subject: [PATCH 07/20] Use run number in link --- .github/workflows/daily.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index ced92918..3720e3a5 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -33,4 +33,4 @@ jobs: if: failure() run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ - -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" + -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/runs/$GITHUB_RUN_NUMBER|$GITHUB_REPOSITORY>.\"}" From d63cf26255c52769e96010e522312541acbd9e24 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 12:34:08 -0800 Subject: [PATCH 08/20] make it more real --- .github/workflows/daily.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 3720e3a5..88ba7496 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -26,11 +26,10 @@ jobs: steps: - uses: actions/checkout@v2 - name: Decrypt test keys - run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem - # - run: cargo test --all-features - - run: exit 1 + # run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem + - run: cargo test --all-features - name: Post to Slack if: failure() run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ - -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/runs/$GITHUB_RUN_NUMBER|$GITHUB_REPOSITORY>.\"}" + -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" From b3fb6033dfa36e23b768108d7db1c005bc31938c Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 12:51:12 -0800 Subject: [PATCH 09/20] Fix dumb typo --- .github/workflows/daily.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 88ba7496..2527906a 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -25,8 +25,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Decrypt test keys - # run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem + # - name: Decrypt test keys + # run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem - run: cargo test --all-features - name: Post to Slack if: failure() From 82621677f58bd1e852d2a1953cf569d1ad1764b3 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 13:06:26 -0800 Subject: [PATCH 10/20] Now make it pass --- .github/workflows/ci.yaml | 2 ++ .github/workflows/daily.yaml | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2769c03e..5b666d78 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -5,6 +5,8 @@ on: branches: - master pull_request: + schedule: + - cron: "0 15 * * 1" # Mondays at 3pm UTC jobs: cargo-test: diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 2527906a..19767b15 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -3,7 +3,7 @@ name: Daily runs # Run daily and also when Cargo.toml changes on: schedule: - - cron: "0 8 * * *" # 8AM UTC + - cron: "0 8 * * *" # Daily at 8am UTC push: branches: - daily-test-hack-day @@ -25,8 +25,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - # - name: Decrypt test keys - # run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem + - name: Decrypt test keys + run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem - run: cargo test --all-features - name: Post to Slack if: failure() From 02652270801be92abbf3608faba76a49db6acc8a Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 13:11:04 -0800 Subject: [PATCH 11/20] Now make it pass for real --- .github/workflows/daily.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 19767b15..88052bf2 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -26,7 +26,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Decrypt test keys - run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem + run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem - run: cargo test --all-features - name: Post to Slack if: failure() From e73b7d77f22fbef7516200d94e3ec1ad2c647e70 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 13:25:09 -0800 Subject: [PATCH 12/20] Set IRONCORE_ENV=dev --- .github/workflows/ci.yaml | 2 +- .github/workflows/daily.yaml | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 5b666d78..6352340c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -6,7 +6,7 @@ on: - master pull_request: schedule: - - cron: "0 15 * * 1" # Mondays at 3pm UTC + - cron: "0 14 * * 1" # Mondays at 2pm UTC jobs: cargo-test: diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 88052bf2..3c7e787f 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -3,7 +3,7 @@ name: Daily runs # Run daily and also when Cargo.toml changes on: schedule: - - cron: "0 8 * * *" # Daily at 8am UTC + - cron: "0 14 * * *" # Daily at 2pm UTC push: branches: - daily-test-hack-day @@ -33,3 +33,5 @@ jobs: run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" + env: + IRONCORE_ENV: dev From c267d072560057ce42e9b8593369a1db39b29332 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 13:38:28 -0800 Subject: [PATCH 13/20] I'm dumb and put it in the wrong place --- .github/workflows/daily.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 3c7e787f..24a620b9 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -13,7 +13,7 @@ on: jobs: security-audit: - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: Run audit checker @@ -28,10 +28,10 @@ jobs: - name: Decrypt test keys run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem - run: cargo test --all-features + env: + IRONCORE_ENV: dev - name: Post to Slack if: failure() run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" - env: - IRONCORE_ENV: dev From 90fe85612b9bf6b4edeed7412a07eb337709efb1 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 13:54:56 -0800 Subject: [PATCH 14/20] Prepare for PR --- .github/workflows/daily.yaml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 24a620b9..5064302e 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -5,11 +5,8 @@ on: schedule: - cron: "0 14 * * *" # Daily at 2pm UTC push: - branches: - - daily-test-hack-day - # paths: - # - "**/Cargo.toml" - workflow_dispatch: + paths: + - "**/Cargo.toml" jobs: security-audit: @@ -25,6 +22,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + # Generate the Cargo.lock that will be used for the tests so we can upload it as an artifact + - run: cargo generate-lockfile + - uses: actions/upload-artifact@v2 + with: + path: Cargo.lock - name: Decrypt test keys run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem - run: cargo test --all-features From 9bfab3df5bce941e61c97e152c30aaeb89ea2788 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 14:13:00 -0800 Subject: [PATCH 15/20] Try to alert of failing main --- .github/workflows/ci.yaml | 5 +++++ .github/workflows/daily.yaml | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6352340c..b5d28715 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -68,6 +68,11 @@ jobs: path: Cargo.lock - name: Cargo test run: cargo test --features ${{ matrix.features }} + - name: Post to Slack on failure in main + if: failure() && github.ref == 'refs/heads/main' + run: | + curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ + -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" cargo-build: runs-on: ${{ matrix.os }} diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 5064302e..09e027e2 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -32,7 +32,7 @@ jobs: - run: cargo test --all-features env: IRONCORE_ENV: dev - - name: Post to Slack + - name: Post to Slack on failure if: failure() run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ From b5e9e82108768a27279f6b3e027f284baf97bef7 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 14:19:31 -0800 Subject: [PATCH 16/20] Alert on failing weekly build as well --- .github/workflows/ci.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b5d28715..283ff4b8 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -115,6 +115,11 @@ jobs: use-cross: true command: build args: --target ${{ matrix.target }} --features "beta blocking tls-rustls" --no-default-features + - name: Post to Slack on failure in main + if: failure() && github.ref == 'refs/heads/main' + run: | + curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ + -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" format: runs-on: ubuntu-18.04 From 60ff5b9a1b39ee903ce372a63d9d15d0ebadc267 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Thu, 4 Mar 2021 14:22:59 -0800 Subject: [PATCH 17/20] Better conditional for on schedule --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 283ff4b8..fb8064d6 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -69,7 +69,7 @@ jobs: - name: Cargo test run: cargo test --features ${{ matrix.features }} - name: Post to Slack on failure in main - if: failure() && github.ref == 'refs/heads/main' + if: failure() && github.event_name == 'schedule' run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" @@ -116,7 +116,7 @@ jobs: command: build args: --target ${{ matrix.target }} --features "beta blocking tls-rustls" --no-default-features - name: Post to Slack on failure in main - if: failure() && github.ref == 'refs/heads/main' + if: failure() && github.event_name == 'schedule' run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ -F "payload={\"text\": \"Failed a run of <$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID|$GITHUB_REPOSITORY>.\"}" From 3995ede02b21ff7be9d2d5dd3d80a203d6869005 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Fri, 5 Mar 2021 11:14:45 -0800 Subject: [PATCH 18/20] Clarify step name --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index fb8064d6..0ec393f8 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -68,7 +68,7 @@ jobs: path: Cargo.lock - name: Cargo test run: cargo test --features ${{ matrix.features }} - - name: Post to Slack on failure in main + - name: Post to Slack on failure of scheduled run if: failure() && github.event_name == 'schedule' run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ @@ -115,7 +115,7 @@ jobs: use-cross: true command: build args: --target ${{ matrix.target }} --features "beta blocking tls-rustls" --no-default-features - - name: Post to Slack on failure in main + - name: Post to Slack on failure of scheduled run if: failure() && github.event_name == 'schedule' run: | curl -L -X POST '${{ secrets.SLACK_WEBHOOK }}' \ From a7848141ee384c1b2d68a0e16007433c72482418 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Fri, 5 Mar 2021 11:40:21 -0800 Subject: [PATCH 19/20] Daily test just default+beta --- .github/workflows/daily.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index 09e027e2..dd123701 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -29,7 +29,7 @@ jobs: path: Cargo.lock - name: Decrypt test keys run: openssl aes-256-cbc -d -K ${{ secrets.OPENSSL_KEY }} -iv ${{ secrets.OPENSSL_IV }} -in tests/testkeys/iak-dev.pem.enc -out tests/testkeys/iak-dev.pem - - run: cargo test --all-features + - run: cargo test --features beta env: IRONCORE_ENV: dev - name: Post to Slack on failure From 9223cf5d77289f963d6bf391207eb3b7a7d5bd32 Mon Sep 17 00:00:00 2001 From: Craig Colegrove Date: Fri, 5 Mar 2021 11:56:44 -0800 Subject: [PATCH 20/20] Weekly test on beta as well --- .github/workflows/ci.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ae894ac4..9e11760b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -33,6 +33,9 @@ jobs: features: tls-rustls --no-default-features - os: ubuntu-18.04 features: tls-vendored-openssl --no-default-features + - os: ubuntu-18.04 + toolchain: beta + features: default # MSRV - os: ubuntu-18.04 toolchain: 1.41.1