Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port spawn_blocking idea to all SDK methods that do significant non-network work #242

Open
skeet70 opened this issue Jul 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@skeet70
Copy link
Member

skeet70 commented Jul 20, 2021

In #241 we discovered that our cryptography and other heavy work done in futures leads to blocking easier/faster network calls under load. To fix decrypt_document we moved heavy work into tokio::spawn_blocking to offload it to a threadpool separate from the one that deals with "normal" futures. We should be doing the same (or similar) everywhere that we do blocking work.

@giarc3 giarc3 added the enhancement New feature or request label Jul 28, 2021
@skeet70
Copy link
Member Author

skeet70 commented Feb 8, 2023

Where do we think we're doing significant blocking work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants