Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the $format parameter to the save method #951

Merged
merged 2 commits into from Jun 24, 2019
Merged

added the $format parameter to the save method #951

merged 2 commits into from Jun 24, 2019

Conversation

rez1dent3
Copy link

Hello.
I have a problem to save the image in the format I need I have to add EXT to it and then move it.

$filepath = $path . '.jpg';
$image->save($filepath);
copy($filepath, $path);
unlink($filepath);

This PR fix this issue.

@olivervogel
Copy link
Member

Thanks. Please write a test for this and add it to the PR. I will merge afterwards.

@rez1dent3
Copy link
Author

@olivervogel done. Added one unit test.

@rez1dent3
Copy link
Author

@olivervogel When do you plan to release?

@olivervogel olivervogel merged commit 39eaef7 into Intervention:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants