Add "jump to" links for keyboard accessibility #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScratchWikiSkinTemplate.php:
+ Jump to sidebar link to logo
+ Jump to content link to first heading
* Have ID for wikilogo
* Escape box header aria label for sidebar, oops...
* Search glass can no longer be tabbed to
resources/css/main.css:
* Make all header links white
+ Hide "jump to" links but allow them to be tabbed to
i18n/*.json:
+ See qqq
Dishonorable mentions:
- Remove the following line from ScratchWikiSkinTemplate.php:
<span class="help-block">Not Required</span>
This has been here since the initial commit and been completely
useless and done absolutely nothing for all 4 years of its life.
We do not thank you for your lack of service.
- Remove the following lines from resources/css/main.css:
#navigation .inner>ul>li.search .row .help-block {
display: none;
}
This has been here since the initial commit and survived the move of
non media-query styling into a new file. It has ensured the complete
uselessness of the <span class="help-block"> mentioned above for all
4 years of its life. Together, they are an even more useless whole.
We do not thank you for your service.
Kenny2github
added
enhancement
Kenny2github
added
accessibility
jacob-g
requested changes
Nov 3, 2021
ScratchWikiSkinTemplate.php:
* Make links into regular navigation links, just ones that are hidden
until they are tabbed to
* This means that when focused, they actually offset the rest of the
navbar to the right a bit, which is fine because it becomes normal
once tabbed away
resources/css/main.css:
- When tabbed to, the links should no longer be position: absolute
|
The links now look like this when tabbed to - hopefully it's better this way: |
jacob-g
approved these changes
Nov 5, 2021
Kenny2github
added
prgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See first commit message for details. Checkout this branch and hit Tab to see it in action.