Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce requirements for idmtools-core #2126

Open
devclinton opened this issue Jul 21, 2023 · 2 comments
Open

Reduce requirements for idmtools-core #2126

devclinton opened this issue Jul 21, 2023 · 2 comments

Comments

@devclinton
Copy link
Member

backoff>=1.10.0,<2.3
coloredlogs~=15.0
more-itertools~=9.0.0
pipreqs>=0.4.10,<0.5
tqdm>=4.52.0,<5
jinja2~=3.1.2
pygit2>=1.4.0,<=1.10.1
tabulate>=0.8.9,<0.10

@devclinton
Copy link
Member Author

@devclinton - Document why this is needed
This needs to move a major release.

We need to move most of this functions from core to cli.

Tqdm is the most difficult as we have to stub it out in core when not available

@shchen-idmod
Copy link
Collaborator

I can only move pygit2 package to cli. and pipreqs seems ok to remove completely. But rest of them are using by core and hard to remove
backoff -- core/asset.py

@backoff.on_exception(backoff.expo, (requests.exceptions.Timeout, requests.exceptions.ConnectionError), max_tries=8)

coloredlogs --core/logging.py
coloredlogs.install(level=logging_config.level, milliseconds=True, stream=sys.stdout)

more-itertools --core/utils/collections.py
from more_itertools import take

tqdm is used in everywhere
jinja2 -- core/plugins/item_sequence.py

tabulate --cores/utils/display/displays.py
from tabulate import tabulate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants