Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createEagerInstances on context-isolation #1382

Merged
merged 1 commit into from Aug 31, 2022
Merged

Add createEagerInstances on context-isolation #1382

merged 1 commit into from Aug 31, 2022

Conversation

rvp-diconium
Copy link
Contributor

It's necessary to call createEagerInstances() when working with context-isolation (library / SDK development) or else singletons declared with single(createdAtStart = true) will be lazily initiated.

@rvp-diconium
Add createEagerInstances on context-isolation
b62176a 
It's necessary to call `createEagerInstances()` when working with context-isolation (library / SDK development) or else singletons declared with `single(createdAtStart = true)` will be lazily initiated.
@arnaudgiuliani arnaudgiuliani added this to the 3.2.1 milestone Aug 29, 2022
@arnaudgiuliani arnaudgiuliani self-requested a review August 29, 2022 14:34
@arnaudgiuliani arnaudgiuliani added status:checking currently in analysis - discussion or need more detailed specs status:accepted accepted to be developed and removed status:checking currently in analysis - discussion or need more detailed specs labels Aug 29, 2022
@arnaudgiuliani
Copy link
Member

thanks for your contribution

@arnaudgiuliani arnaudgiuliani merged commit a343277 into InsertKoinIO:main Aug 31, 2022
arnaudgiuliani added a commit that referenced this pull request Aug 31, 2022
@arnaudgiuliani
changelog update for #1382
970fba0
@rvp-diconium rvp-diconium deleted the patch-1 branch October 13, 2022 13:32
@rvp-diconium
Copy link
Contributor Author

hey @arnaudgiuliani ,
I thought those changes would get mirrored to https://insert-koin.io/docs/reference/koin-core/context-isolation after some CI process to update the site. But apparently not.

Is there some other markdown I should update too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudgiuliani arnaudgiuliani Awaiting requested review from arnaudgiuliani

Assignees
No one assigned
Labels
core status:accepted accepted to be developed type:issue
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvp-diconium @arnaudgiuliani