Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep-optional default true or ask user about removal. #56

Open
thomasez opened this issue Jun 4, 2014 · 2 comments
Open

keep-optional default true or ask user about removal. #56

thomasez opened this issue Jun 4, 2014 · 2 comments

Comments

@thomasez
Copy link

thomasez commented Jun 4, 2014

The behaviour now is that parameters in .yml are silently removed if they are not in yml.dist.

I propose that either keep-optional is default true, so this will not happen, or better, ask the user if it's supposed to be removed or not.

I just did a quick upgrade form sf 2.5.0 beta 2 to release on my dev instance, which was in the middle of a change possibly needing a new parameter. That just went without a puff of smoke. And since parameters.yml shall not be in CVS (git), I have to recreate the new parameters.

I've added keep-optional now, but this was behaviour that was "silently" added in some update of Symfony, which pulled this package, with this new behaviour. I qould guess that more developers than me will be surprised by this :=)

@stof
Copy link
Member

stof commented Jun 4, 2014

it was never silently added in any version of Symfony. The very first commit of the ParameterHandler did not have the keep-outdated flag (it is not named keep-optional), but its behavior was already to drop them

@thomasez
Copy link
Author

thomasez commented Jun 5, 2014

What was added was the parameter handling (which was a very good thing). I guess I never got hit by the removal until now, so that part was kinda silent for me.

Still, I would like that option of asking "whall I remove" when running interactive, since I then can decide, like keep it in dev environment, but have it automatically removed in staging and prodution.

If this is something that would be include I'd make a patch for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants