-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expiring funding goals #136
Comments
re: fundingGoal value, how do you think we should handle potential different currency types? |
@goblinodds Just USD for now. :-) |
i keep running into trickiness with Decimals; maybe there's something goofy i'm doing wrong? (maybe i should use Float but this seemed to come with its own issues) typescript seems to handle prisma Decimals as strings but wants them to be 'string | undefined' and sort of forces this (will add “undefined” to the end in the background if you try to assign things to 'string | null') mostly i've been able to work with this but:
i'm not super sure how to handle that. i set things up to calculate a quarterDonationTotal, which can be zero. |
@goblinodds Ow, how badly blocked are you on that? I imagine considering |
yeah i think that would help!! sorry, keep getting migraines this week for some reason, hoping to be able to try this out in like 2 days x_x |
Two observations:
What do you all think about expiring funding goals:
gets a reminder email to update the funding goal andis not, by default, displayed anymore.That should make it fairly likely that a project that is displayed by default is also fundraising at the time. It'll reduce the number of tied projects, removing such that just accept donations because it's easy for them and not because they need them enough to spend two minutes to update a number.
Update: It's probably easier to have all funding goals expire at the end of the quarter because then we don't have to implement the transactional emails but can just send a BCC email from Gmail.
Technically, I imagine something like:
updatedAt
(already exists) andfundingGoal
(new).fundingGoal
is consider null (regardless of its actual value) ifupdatedAt
is in the last quarter.In terms of the design, maybe we can add a thin Mantine progress bar at the bottom of each project card. No text at first sight, but current funding goal and progress toward it in a tooltip.
On the project page, it can go all the way at the top, right below the title, so that the “Accepting donations” button flows from it visually as it were. Same colors ideally. (The certificates already have this much more complex progress bar.)
On the edit page, the new field for the funding goal and an explanation can go to the right of the payment URL, both half width.
The text was updated successfully, but these errors were encountered: