Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all Grid samples to take the full window height when opened alone #3250

Open
zdrawku opened this issue Feb 21, 2023 · 7 comments · Fixed by #3257
Open

Set all Grid samples to take the full window height when opened alone #3250

zdrawku opened this issue Feb 21, 2023 · 7 comments · Fixed by #3257

Comments

@zdrawku
Copy link
Contributor

zdrawku commented Feb 21, 2023

Description

Previously we had to set a fixed heights in order for the Grid to fit the iframe, but now the iframe is sized based on the codeview container and its okay to set grid's height and its parent element to be with height:100% in order to take the full size within the code view and at the same time be with full screen size when opened alone.

Example with CRM Grid:
image

Full screen:
image

@zdrawku
Copy link
Contributor Author

zdrawku commented Feb 21, 2023

@hanastasov, for the time being please make only this sample app with 100% height in order to unblock the marketing team for their video campaign:
https://www.infragistics.com/angular-demos/hierarchical-grid/hierarchical-grid-toolbar-pinning

@monacodelisa monacodelisa changed the title Set all Grid samples width to be 100% Set all Grid samples height to be 100% Feb 21, 2023
@monacodelisa monacodelisa changed the title Set all Grid samples height to be 100% Set all Grid samples width to be 100% Feb 21, 2023
@zdrawku zdrawku changed the title Set all Grid samples width to be 100% Set all Grid samples width to be 100% height Feb 21, 2023
@zdrawku
Copy link
Contributor Author

zdrawku commented Feb 22, 2023

@monacodelisa I should have defined the acceptance criteria better, the expected result is the grid to take the full window width. It looks like setting height to 100% is not enough in that case:

image

@zdrawku zdrawku changed the title Set all Grid samples width to be 100% height Set all Grid samples to take the full window height when opened alone Feb 22, 2023
@zdrawku
Copy link
Contributor Author

zdrawku commented Feb 22, 2023

Also @monacodelisa please add one more thing, the marketing team would love to have theme switcher on the sample in order to open it in dark mode. We already have a sample that is doing so, example below. Use it as a reference to achieve it for the hierarchical-grid-toolbar-pinning.

White:
https://www.infragistics.com/angular-demos-grid-crm
Dark:
https://www.infragistics.com/angular-demos-grid-crm/?dark=true

@zdrawku
Copy link
Contributor Author

zdrawku commented Feb 22, 2023

@hanastasov would it be possible to consider adding the dark theme switch capabilities to all angular samples? I guess it might be challenging in order to came up with at idea that covers all samples, but the time spend on this will pay in the future as the marketing team will continue using our sample for their campaigns.

@hanastasov
Copy link
Contributor

@sharon-IG
Copy link

MicrosoftTeams-image (181)
When I drill down, there is a lot of empty space (not showing many columns).

Can we apply a theme to this sample so it has more color, or dark theme would be fine. Thanks

@zdrawku
Copy link
Contributor Author

zdrawku commented Mar 20, 2023

I am removing this item from the sprint, we have other priorities to focus on and probably will get back to it some of the upcoming iterations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants