Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API doesn't allways succeed in removing a topic (job_id) from the RabbitMQ client when it is done with streaming logs. #5829

Open
1 task done
bisgaard-itis opened this issue May 15, 2024 · 1 comment
Assignees
Labels
a:apiserver api-server service bug buggy, it does not work as expected

Comments

@bisgaard-itis
Copy link
Contributor

bisgaard-itis commented May 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Ideas and thoughts

  • One thing which should definititely be done is to modify the current health check in the API-server so that each time the background task runs it registers the dummy job_id and unregisters it again. The "leaking" of job_ids would probably be detected by this check.
  • Figure out if there is a bullet-proof way to ensure that a topic is deregistered. Would it e.g. be possible to ask the RabbitMq server periodically and check that all job_ids which are not streaming logs should be deregistered. I would like to discuss this with you @sanderegg
  • Probably this will also be a bottleneck if a sufficient number of users stream logs via the API server at the same time. So it might be worth considering ways to communicate this to the orchestrator to spin up additional replicas of the api-server.
@bisgaard-itis bisgaard-itis added the bug buggy, it does not work as expected label May 15, 2024
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label May 15, 2024
@bisgaard-itis bisgaard-itis added this to the Leeroy Jenkins milestone May 15, 2024
@bisgaard-itis
Copy link
Contributor Author

@mguidon FYI
I suspect this is the reason behind the log streaming issues we face sometimes.

@bisgaard-itis bisgaard-itis changed the title API doesn't allways succeed in removing a topic (job_id) from the RabbitMQ client when it is done with straming logs. API doesn't allways succeed in removing a topic (job_id) from the RabbitMQ client when it is done with streaming logs. May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service bug buggy, it does not work as expected
Projects
None yet
Development

No branches or pull requests

2 participants