Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: improve error handling #4664

Closed
pcrespov opened this issue Aug 25, 2023 · 0 comments · Fixed by #5866
Closed

API: improve error handling #4664

pcrespov opened this issue Aug 25, 2023 · 0 comments · Fixed by #5866
Assignees
@pcrespov
Labels
t:maintenance Some planned maintenance work
Milestone
Leeroy Jenkins

Comments

@pcrespov
Copy link
Member

pcrespov commented Aug 25, 2023 •
edited

  • httpx_client_error_handler is dangerously generic since it forwards client's errors of any httpx calls on the api-server . E.g. there is a risk of revealing secrets.
  • backend APIs error must be specified (they should be in OAS) and handled by the api-server appropriately before responding the client. Remember that the api-server is an aggregator and gateway to our system
    • See e.g. ProjectNotFoundError as example
  • services/webserver error handling needs some extra love!
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Aug 25, 2023
@pcrespov pcrespov self-assigned this Aug 25, 2023
@pcrespov pcrespov added this to the Baklava milestone Aug 25, 2023
@pcrespov pcrespov modified the milestones: Baklava, the nameless Sep 13, 2023
@sanderegg sanderegg removed this from the the nameless milestone Apr 12, 2024
@pcrespov pcrespov added this to the Leeroy Jenkins milestone May 23, 2024
@pcrespov pcrespov mentioned this issue May 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcrespov pcrespov

Labels
t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Leeroy Jenkins
Development

Successfully merging a pull request may close this issue.

♻️🎨 Improves error handling in the api-server pcrespov/osparc-simcore
2 participants
@pcrespov @sanderegg