From b060dd4b858b72072fb7b052eea7058d55d6cbd1 Mon Sep 17 00:00:00 2001 From: Vlad Gorodetsky Date: Thu, 24 Dec 2020 06:27:22 +0200 Subject: [PATCH 1/3] Fix CI setenv permissions issues --- .github/workflows/ci.yml | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4fe121a4e..1e0ef06c4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,21 +31,17 @@ jobs: key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} restore-keys: | ${{ runner.os }}-go- - - # See https://github.com/actions/setup-go/issues/14 - - name: Setup env - run: | - echo "::set-env name=GOPATH::$(go env GOPATH)" - echo "::add-path::$(go env GOPATH)/bin" - shell: bash - - name: Install dependencies run: | - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.31.0 + curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0 export REPOSITORY_ROOT=${GITHUB_WORKSPACE} - name: Run test suite - run: make test_functional + run: | + export PATH=$PATH:$(go env GOPATH)/bin # temporary fix. See https://github.com/actions/setup-go/issues/14 + make test_functional - name: Run linter - run: make lint + run: | + export PATH=$PATH:$(go env GOPATH)/bin # temporary fix. See https://github.com/actions/setup-go/issues/14 + make lint From d3d1ce5013243ca53af973e127f50a77e8ee2d38 Mon Sep 17 00:00:00 2001 From: Vlad Gorodetsky Date: Thu, 24 Dec 2020 06:29:09 +0200 Subject: [PATCH 2/3] Use setup-go v2 --- .github/workflows/ci.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1e0ef06c4..e5204dc7c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,7 @@ jobs: - uses: actions/checkout@v1 - name: Setup Go - uses: actions/setup-go@v1 + uses: actions/setup-go@v2 with: go-version: ${{ matrix.go-version }} @@ -31,17 +31,14 @@ jobs: key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} restore-keys: | ${{ runner.os }}-go- + - name: Install dependencies run: | curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0 export REPOSITORY_ROOT=${GITHUB_WORKSPACE} - name: Run test suite - run: | - export PATH=$PATH:$(go env GOPATH)/bin # temporary fix. See https://github.com/actions/setup-go/issues/14 - make test_functional + run: make test_functional - name: Run linter - run: | - export PATH=$PATH:$(go env GOPATH)/bin # temporary fix. See https://github.com/actions/setup-go/issues/14 - make lint + run: make lint From 6784b79f6dca76432958470161b37a651de74fe1 Mon Sep 17 00:00:00 2001 From: Vlad Gorodetsky Date: Thu, 24 Dec 2020 06:33:25 +0200 Subject: [PATCH 3/3] Use checkout@v2 and cache@v2 --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e5204dc7c..549b3bfed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,14 +18,14 @@ jobs: KAFKA_VERSION: ${{ matrix.kafka-version }} steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 - name: Setup Go uses: actions/setup-go@v2 with: go-version: ${{ matrix.go-version }} - - uses: actions/cache@v1 + - uses: actions/cache@v2 with: path: ~/go/pkg/mod key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}