Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concern Regarding the rcrowley/go-metrics Dependency #2832

Open
PaigeOmmen opened this issue Mar 15, 2024 · 2 comments
Open

Concern Regarding the rcrowley/go-metrics Dependency #2832

PaigeOmmen opened this issue Mar 15, 2024 · 2 comments

Comments

@PaigeOmmen
Copy link

I noticed that there had been discussion in Sarama roadmap around the replacement of rcrowley/go-metrics with something like prometheus's Golang client. However, that conversation is nearly 4 years old and the rcrowley/go-metrics project remains generally unmaintained. So, I wanted to open a unique issue to bring attention to that particular concern. I understand that such a replacement of that dependency would introduce breaking changes to any projects leveraging those metrics, but I think upgrading Sarama's metric gathering component to depend on something with regular updates would benefit the project's security and integrability.

@RainbowMango
Copy link

+1 on replacement of rcrowley/go-metrics

@cjh-mastering
Copy link

+1 it seems that go-metrics may invoke memory leak problem, #1321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants