PartitionOffsetManager.Close deadlock without autocommit #2772
Labels
bug
needs-investigation
Issues that require followup from maintainers
stale
Issues and pull requests without any recent activity
Description
PartitionOffsetManager.Close()
function deadlocks whenThe
Close()
function relies onpom.errors
channel being closed.It never is as the offset manager
mainLoop
is never initialized if auto-commit is disabled.I believe this behaviour is not acceptable. As a Sarama user I'd expect the called functions to return an error (or panic) if used inappropriately, but never deadlock.
Gist with code reproducing the issue: https://gist.github.com/maciej/d5be479a3576b01a1f5f145aaa803ca1
Versions
(listing Go and Kafka versions, but these are irrelevant to this bug)
Configuration
Already specified.
Logs
N/A
Additional Context
N/A
The text was updated successfully, but these errors were encountered: