New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go version in go.mod to avoid use v1.37.0 with Go 1.16 #2354
Comments
😔 whilst I'd seen "deprecate go1.16" in the release notes of v1.15.10 I hadn't spotted that this actually introduced a breaking change (dropping the old +build comments) |
officially Sarama only officially supports and tests on N and N-1 versions of Go, but it would have been nice if we'd spotted this pre-release |
opened #2357 |
🤔 I think the release note was not clear. It should be the minimal requirement is Go 1.17 instead of just |
Merged and released |
Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Configuration
Run any unit test with Go 1.16
Logs
Problem Description
In #2349,
github.com/klauspost/compress
is upgraded tov1.15.11
, which require at leastGo 1.17
(link). However, the minimal Go version in sarama is stillGo 1.16
(link). Thus, ifGo 1.16
is used, compilation will fail.I think it's time to upgrade Go version in go.mod.
The text was updated successfully, but these errors were encountered: