Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version in go.mod to avoid use v1.37.0 with Go 1.16 #2354

Closed
napallday opened this issue Oct 3, 2022 · 5 comments
Closed

Upgrade Go version in go.mod to avoid use v1.37.0 with Go 1.16 #2354

napallday opened this issue Oct 3, 2022 · 5 comments

Comments

@napallday
Copy link
Contributor

Versions

Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.

Sarama Kafka Go
v1.37.0 1.16
Configuration

Run any unit test with Go 1.16

Logs

../../go/pkg/mod/github.com/klauspost/compress@v1.15.11/zstd/blockdec.go:17:2: //go:build comment without // +build comment
zstd.go:6:2: //go:build comment without // +build comment

Problem Description

In #2349, github.com/klauspost/compress is upgraded to v1.15.11, which require at least Go 1.17(link). However, the minimal Go version in sarama is still Go 1.16(link). Thus, if Go 1.16 is used, compilation will fail.

I think it's time to upgrade Go version in go.mod.

@dnwe
Copy link
Collaborator

dnwe commented Oct 4, 2022

😔 whilst I'd seen "deprecate go1.16" in the release notes of v1.15.10 I hadn't spotted that this actually introduced a breaking change (dropping the old +build comments)

@dnwe
Copy link
Collaborator

dnwe commented Oct 4, 2022

officially Sarama only officially supports and tests on N and N-1 versions of Go, but it would have been nice if we'd spotted this pre-release

@dnwe
Copy link
Collaborator

dnwe commented Oct 4, 2022

opened #2357

@napallday
Copy link
Contributor Author

😔 whilst I'd seen "deprecate go1.16" in the release notes of v1.15.10 I hadn't spotted that this actually introduced a breaking change (dropping the old +build comments)

🤔 I think the release note was not clear. It should be the minimal requirement is Go 1.17 instead of just deprecate Go 1.16.

@dnwe
Copy link
Collaborator

dnwe commented Oct 4, 2022

Merged and released

@dnwe dnwe closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants