Skip to content

fix: via link resolving for npm 7 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix: via link resolving for npm 7 #184

merged 1 commit into from
Jun 15, 2021

Conversation

p-v-d-Veeken
Copy link
Contributor

Fixes: #183

@wilgert
Copy link

wilgert commented Jun 8, 2021

I see that the build fails on audit vulnerabilities should we fix that or will you fix it in IBM:master and should we rebase?

@quinnturner quinnturner self-requested a review June 13, 2021 17:43
@quinnturner
Copy link
Member

quinnturner commented Jun 13, 2021 •
edited
Loading

Hi there, thank you for the PR! I will update the audit vulnerabilities separately on master for you to rebase shortly.

EDIT: I have updated master to fix npm audit issues. Thanks for the heads up. You are ready to rebase!

quinnturner
quinnturner reviewed Jun 13, 2021
View reviewed changes
@quinnturner quinnturner mentioned this pull request Jun 14, 2021
Merged
@p-v-d-Veeken
Copy link
Contributor Author

Updated the pr with the commits from master and changed to a do-while loop :)

@quinnturner quinnturner self-assigned this Jun 15, 2021
@quinnturner quinnturner self-requested a review June 15, 2021 11:17
@quinnturner quinnturner merged commit 89c6569 into IBM:master Jun 15, 2021
@quinnturner
Copy link
Member

Released in v4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnturner quinnturner

Assignees

@quinnturner quinnturner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit-ci fails on nested via links
3 participants
@p-v-d-Veeken @wilgert @quinnturner