Identify FTZ-causing library #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
better-ftz-error
branch
from
ddf72c9
to
2dd25f0
Compare
honno
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Nice work. The base problem of identifying a culprit seemed annoying-enough, and this goes above and beyond.
Manual test worked locally. I didn't practically explore other scenarios like FTZ Python builds because... yaknow.
As an aside, I'm totally ignorant of multi-processing things so was wondering if there's a noob-friendly way to use breakpoints for the "original thread" code? The ever reliable Seems print() served my exploratory needs in any case.breakpoint() works fine, was using ipdb which is doing something funky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3458 the complete overkill way, because once I got started each incremental part wasn't that hard to add... and if you're trying to understand what's going on here I'd like to help as much as possible.
cc @catherio FYI.