Skip uninformative locations in explain mode, misc internal cleanups #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
annotate-internals
branch
5 times, most recently
from
cee003f
to
28574fa
Compare
This never actually worked, because the __module__ string doesn't have a __name__ attribute. Since we want DB keys to be independent of the file anyway, we'll just delete the clause.
Co-Authored-By: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Zac-HD
force-pushed
the
annotate-internals
branch
4 times, most recently
from
f1410bb
to
427d700
Compare
Zac-HD
force-pushed
the
annotate-internals
branch
from
427d700
to
90c4b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a grab-bag of small stuff that's been niggling at me lately, and there's little enough user-facing just to release both together. Closes #3397, closes #3439, closes #3441.