Use inspect.signature() for argument conversion and define_function_signature()
#3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
use-signature-everywhere
branch
2 times, most recently
from
3ff4504
to
08181fb
Compare
Zac-HD
commented
Jun 28, 2022
Comment on lines
-81
to
+75
| assert out == ((), {"a": 1, "b": 2}) | ||
| assert out == ((), {"a": 1}) |
There was a problem hiding this comment.
This is a deliberate change for consistency: the previous behaviour of convert_positional_arguments() applied default arguments only for keyword-only params, which could lead to some weird reprs for strategies. Fortunately it can't affect @given(), because there it's an explicit error to have default values!
Comment on lines
-62
to
-66
| def test_populates_defaults(): | ||
| def bar(x=[], y=1): | ||
| pass | ||
|
|
||
| assert convert_keyword_arguments(bar, (), {}) == (([], 1), {}) |
There was a problem hiding this comment.
A surprisingly complementary case to the above: previously this would populate defaults for pos-or-keyword arguments, but not for keyword-only. As above, we resolved the inconsistency in favor of passing fewer arguments.
Zac-HD
force-pushed
the
use-signature-everywhere
branch
5 times, most recently
from
9a37739
to
a223db8
Compare
Zac-HD
force-pushed
the
use-signature-everywhere
branch
from
a223db8
to
98734be
Compare
honno
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good chunk of the remaining work on #2706.
I'd suggest reviewing commit-by-commit, and TBH leaning pretty heavily on all the tests passing.