Fix InferType and improve type-checker tests
#3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsokl
added
tests/build/CI
Zac-HD
reviewed
Jun 25, 2022
whole-repo-tests/test_mypy.py
Outdated
| @@ -16,6 +16,8 @@ | |||
| from hypothesistooling.projects.hypothesispython import PYTHON_SRC | |||
| from hypothesistooling.scripts import pip_tool, tool_path | |||
|
|
|||
| PYTHON_VERSIONS = [f"3.{v}" for v in range(7, 11)] | |||
There was a problem hiding this comment.
I think I'd prefer to write these out as literals, unless we can pull them out of the autoupdated CI config? Just thinking about how they'll stay up to date. I think we can also test against 3.11?
You mean pinned pyright version, right? |
Zac-HD
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3379
cb05529 and db5ed42 should make the test suite fail. (our pyright tests would fail for db5ed42 if we were using the
pyright1.1.250 or above)