Handle all builtin types in st.from_type(), including via Type[...] and ForwardRef(...)
#2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
handle-builtins
branch
3 times, most recently
from
5f54d8d
to
4961225
Compare
sobolevn
reviewed
Mar 11, 2021
| assert isinstance(v, t) | ||
|
|
||
|
|
||
| @pytest.mark.skipif(sys.version_info[:2] == (3, 6), reason="no ForwardRef type") |
There was a problem hiding this comment.
I think that compat hack now handles 3.6, doesn't it?
There was a problem hiding this comment.
Alas, in 3.6 _ForwardRef requires that it be called on a type object. For some reason.
See https://github.com/HypothesisWorks/hypothesis/runs/2084980210?check_suite_focus=true for all the failures when I tried 😭
This was referenced Mar 11, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2892 and #2896, it occurred to me that (absent a registered strategy to the contrary) it's safe to assume that forward-references to the name of a builtin type does in fact refer to that builtin. This PR implements exactly that logic... and registers all the remaining builtin types, so that we can write the obvious tests.