Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Python versions to newer ones #2890

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 5, 2021

It is time to update the tooling with new security releases 馃攼

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zac-HD
Copy link
Member

Zac-HD commented Mar 5, 2021

I've been idly wondering about automating this as part of our weekly dependency update job... it's low enough priority that I haven't done anything, since I'm also unconvinced that maintaining the script (for eg EOL and prerelease pythons) would actually be less effort than doing it by hand. Maybe just a helper to report the latest versions available from pyenv?

@sobolevn
Copy link
Member Author

sobolevn commented Mar 5, 2021

@Zac-HD
Copy link
Member

Zac-HD commented Mar 5, 2021

We already have the actions part working - we'd just need to drop some python code in

def upgrade_requirements():
compile_requirements(upgrade=True)
subprocess.call(["./build.sh", "format"], cwd=tools.ROOT) # exits 1 if changed
if hp.has_source_changes() and not os.path.isfile(hp.RELEASE_FILE):
with open(hp.RELEASE_FILE, mode="w") as f:
f.write(
"RELEASE_TYPE: patch\n\nThis patch updates our autoformatting "
"tools, improving our code style without any API changes.\n"
)

which bumps the Python versions.

@sobolevn
Copy link
Member Author

sobolevn commented Mar 5, 2021

@Zac-HD Thanks! Do you want to include some extra infra code in this PR or can I merge it?

@Zac-HD
Copy link
Member

Zac-HD commented Mar 5, 2021

Merge away! As I said above, automating this is low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants