Improved the check_type and check_valid_size validation functions #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgrainge
force-pushed
the
validation
branch
3 times, most recently
from
fccad72
to
c1873ae
Compare
Zac-HD
reviewed
Sep 9, 2019
tomgrainge
force-pushed
the
validation
branch
from
c1873ae
to
7f7a665
Compare
|
I am not quite sure why the coverage tests are still failing. I have tried to run the coverage tests on my local machine by they do not show up any issues unfortunately. |
|
I believe that you need a test in which |
|
@rsokl - nope, it's actually a custom checker we have for validation helpers, not the coverage library. It'll be easier for me to push a fix than explain I think! |
A couple of minor improvements have been made: - The check_type function now tests for lists of length 1 so the returned mesaging is better. - check_valid_size() now passes the name variable into check_type as this is a required argument. To cover the additional logic within check_type a new test has been added in the test_validation file.
|
Hey, thanks for getting it past that CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of minor improvements have been made:
returned mesaging is better.
as this is a required argument.
This fixes #2083.