Remove the ability to run a single shrink pass #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRMacIver
commented
Jul 2, 2019
| @@ -1539,25 +1518,6 @@ def shrinker(data): | |||
| assert shrinker.calls <= 60 | |||
|
|
|||
|
|
|||
| def test_zero_examples_does_not_try_to_adapt_across_different_sizes(): | |||
There was a problem hiding this comment.
I removed this test because I couldn't figure out a sensible way to adapt it and it seemed fragile and hyper-specific.
Zalathar
reviewed
Jul 3, 2019
|
|
||
| def run(self): | ||
| return self.run_shrink_pass(definition.name) | ||
| assert False, "Shrink passes should not be run directly" |
There was a problem hiding this comment.
This is what's causing the coverage failure, so presumably it just needs to be suppressed.
There was a problem hiding this comment.
Huh. I thought the assert False was automatically a coverage exclusion. Oh well, easy enough to add the pragma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was only used for testing, and was about to become more awkward to support in some changes I have planned, so this removes it entirely and makes it an error to call a shrink pass directly.