Don't run apt-get commands from the whole repo test suite #2032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to how we install shellcheck in #2026 mean that the whole repo tests can only be run as root (and attempt to install things globally), which isn't ideal in general and prevents local usage. This PR changes it so that the build will still use the old method to install shellcheck if it's not found, but will use a system one if present, and updates our build config to install shellcheck before the tests are run.