Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds strategy for advanced indexing with integer-arrays #2019

Merged
merged 1 commit into from Jul 4, 2019
Merged

Adds strategy for advanced indexing with integer-arrays #2019

merged 1 commit into from Jul 4, 2019

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented Jun 24, 2019 •
edited

Closes #1931

@rsokl rsokl changed the title Adv int indexing Adds strategy for advanced indexing with integer-arrays Jun 24, 2019
@rsokl rsokl requested a review from Zac-HD June 24, 2019 16:28
@Zac-HD Zac-HD added the new-feature entirely novel capabilities or strategies label Jun 25, 2019
Zac-HD
Zac-HD reviewed Jun 25, 2019
View reviewed changes
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of fiddly little comments, but the substance of the PR looks great. Thanks again @rsokl!

hypothesis-python/RELEASE.rst Outdated Show resolved Hide resolved
hypothesis-python/src/hypothesis/extra/numpy.py Outdated Show resolved Hide resolved
hypothesis-python/src/hypothesis/extra/numpy.py Outdated Show resolved Hide resolved
hypothesis-python/src/hypothesis/extra/numpy.py Outdated Show resolved Hide resolved
hypothesis-python/src/hypothesis/extra/numpy.py Outdated Show resolved Hide resolved
hypothesis-python/tests/numpy/test_gen_data.py Outdated Show resolved Hide resolved
hypothesis-python/src/hypothesis/extra/numpy.py Outdated Show resolved Hide resolved
@rsokl
Copy link
Contributor Author

rsokl commented Jul 4, 2019

@Zac-HD This looks good to me! Unfortunately, I cannot review it since it is my PR originally.

Zac-HD
Zac-HD approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll say it looks good to me too!

@Zac-HD Zac-HD merged commit 8d64510 into master Jul 4, 2019
@Zac-HD Zac-HD deleted the adv_int_indexing branch July 4, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zac-HD Zac-HD Zac-HD approved these changes

Assignees
No one assigned
Labels
new-feature entirely novel capabilities or strategies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Numpy strategy advanced_integer_indexes(shape, result_shape=array_shapes())
2 participants
@rsokl @Zac-HD