Deprecate the buffer_size setting #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
deprecate-buffer-size
branch
from
157cc63
to
c3a78e6
Compare
Zac-HD
force-pushed
the
deprecate-buffer-size
branch
from
c3a78e6
to
15fd577
Compare
DRMacIver
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the vaguely-on-the-todo-list-for-ages department, we expose the
buffer_sizesetting to users... even though it's deeply entwined with implementation details and basically impossible to set beyond "more than the default" (and doing so is usually unhelpful).So this PR closes #1233 by deprecating the setting and ignoring it in favour of an internal constant.