Replace bleach due to depreciation #3693
Labels
Comments
|
the folks who made |
frjo
pushed a commit
that referenced
this issue
Mar 11, 2024
Fixes #3693 Aims to fully replace bleach with nh3 due to bleach deprecation. Currently, [django-nh3](https://github.com/marksweb/django-nh3) is in it's infancy, but seems like it could be an almost drop in replacement for [django-bleach](https://github.com/marksweb/django-bleach), for I [forked it](https://github.com/wes-otf/django-nh3) and made some small additions that would allow it to work for our purposes and be smoothly migrated. Initial smoke testing in Hypha seems to work exactly as bleach did but needs more extensive testing. Ideally I would smooth out some edges of my fork and put in a PR to django-nh3. Let me know any thoughts/questions!
wes-otf
added a commit
that referenced
this issue
May 7, 2024
Fixes #3693 Aims to fully replace bleach with nh3 due to bleach deprecation. Currently, [django-nh3](https://github.com/marksweb/django-nh3) is in it's infancy, but seems like it could be an almost drop in replacement for [django-bleach](https://github.com/marksweb/django-bleach), for I [forked it](https://github.com/wes-otf/django-nh3) and made some small additions that would allow it to work for our purposes and be smoothly migrated. Initial smoke testing in Hypha seems to work exactly as bleach did but needs more extensive testing. Ideally I would smooth out some edges of my fork and put in a PR to django-nh3. Let me know any thoughts/questions!
wes-otf
added a commit
that referenced
this issue
May 8, 2024
Fixes #3693 Aims to fully replace bleach with nh3 due to bleach deprecation. Currently, [django-nh3](https://github.com/marksweb/django-nh3) is in it's infancy, but seems like it could be an almost drop in replacement for [django-bleach](https://github.com/marksweb/django-bleach), for I [forked it](https://github.com/wes-otf/django-nh3) and made some small additions that would allow it to work for our purposes and be smoothly migrated. Initial smoke testing in Hypha seems to work exactly as bleach did but needs more extensive testing. Ideally I would smooth out some edges of my fork and put in a PR to django-nh3. Let me know any thoughts/questions!
Vldln
pushed a commit
to equalitie/hypha
that referenced
this issue
May 28, 2024
Fixes HyphaApp#3693 Aims to fully replace bleach with nh3 due to bleach deprecation. Currently, [django-nh3](https://github.com/marksweb/django-nh3) is in it's infancy, but seems like it could be an almost drop in replacement for [django-bleach](https://github.com/marksweb/django-bleach), for I [forked it](https://github.com/wes-otf/django-nh3) and made some small additions that would allow it to work for our purposes and be smoothly migrated. Initial smoke testing in Hypha seems to work exactly as bleach did but needs more extensive testing. Ideally I would smooth out some edges of my fork and put in a PR to django-nh3. Let me know any thoughts/questions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure if this has been discussed yet (so I apologize if I'm duplicating here) but I stumbled upon a notice that bleach was being depreciated: mozilla/bleach#698. While their depreciation plan looks to be a slow and coordinated one, it would probably help to start looking at & implementing alternatives.
One that's mentioned in that issue thread is the rust-based Ammonia library, which has had python bindings built via the nh3 project. It looks like this also might come with some serious performance improvements as well (woooo rust!).
The text was updated successfully, but these errors were encountered: