Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Korean formatter #1095

Merged
merged 1 commit into from Jul 3, 2021
Merged

Conversation

hangy
Copy link
Contributor

@hangy hangy commented Jun 24, 2021

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

Registers a formatter for the existing Korean translations. The unit test is merely to verify that the translations are picked up, and are based on the Resources and Google translate, because I do not speak Korean.

Fixes #1073

@clairernovotny clairernovotny merged commit e023645 into Humanizr:main Jul 3, 2021
@hangy hangy deleted the register-ko branch July 3, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeSpan.FromXXX no translated for "ko-KR"
2 participants