Admin tags and categories #79

appinteractive · 2018-12-08T13:08:32Z

Use with Human-Connection/Nitro-Backend#62

Added Tags and Categories to the Admin area

roschaefer

When I run docker-compose up --build I get the following error:

ERROR in ./styleguide/src/system/components/data-input/Select/style.scss?vue&type=style&index=0&lang=scss& (./node_modules/css-loader??ref--6-oneOf-1-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/src??ref--6-oneOf-1-2!./node_modules/sass-loader/lib/loader.js??ref--6-oneOf-1-3!./node_modules/sass-resources-loader/lib/loader.js??ref--6-oneOf-1-4!./styleguide/src/system/components/data-input/Select/style.scss?vue&type=style&index=0&lang=scss&)
Module build failed (from ./node_modules/sass-loader/lib/loader.js):

}
          ^
      Undefined variable: "$z-index-dropdown".
      in /nitro-web/styleguide/src/system/components/data-input/Select/style.scss (line 129, column 12)
 @ ./styleguide/src/system/components/data-input/Select/style.scss?vue&type=style&index=0&lang=scss& (./node_modules/vue-style-loader!./node_modules/css-loader??ref--6-oneOf-1-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/src??ref--6-oneOf-1-2!./node_modules/sass-loader/lib/loader.js??ref--6-oneOf-1-3!./node_modules/sass-resources-loader/lib/loader.js??ref--6-oneOf-1-4!./styleguide/src/system/components/data-input/Select/style.scss?vue&type=style&index=0&lang=scss&) 4:14-452
 @ ./styleguide/src/system/components/data-input/Select/style.scss?vue&type=style&index=0&lang=scss&
 @ ./styleguide/src/system/components/data-input/Select/Select.vue
 @ ./styleguide/src/system/components sync \.vue$
 @ ./styleguide/src/system/components/index.js
 @ ./styleguide/src/system/index.js
 @ ./plugins/design-system.js
 @ ./.nuxt/index.js
 @ ./.nuxt/client.js
 @ multi ./.nuxt/client.js

Also, please add component tests to this PR. Component tests should be easy to setup as we did it once already for our previous WebApp.

…gories

appinteractive · 2018-12-10T11:52:42Z

Then the docker pipeline is not working correctly. Locally and on Travis it works correctly. @roschaefer for that you are currently the expert. Any suggestions?

roschaefer · 2018-12-10T17:26:41Z

My suggestion for you is to run docker-compose up --build on your laptop and get back to me. 🤗

roschaefer · 2018-12-10T17:28:04Z

My other suggestion is to run docker-compose more often. Use it for development. Buy hardware if necessary, my laptop was 600€. If the developer would use docker-compose for their development environment, we would run into less errors.

appinteractive · 2018-12-10T17:37:33Z

As I do not use pc as my driver I would be way more then 600€. So I can’t afford it at the moment. And as docker is frying my seven year old machine. So I will use the powers of my native system for now 😉

roschaefer · 2018-12-10T22:55:19Z

@appinteractive I see the above bug on master now. What has happened?

…gories

roschaefer · 2018-12-10T23:34:09Z

I am finally able to build the docker container but just don't know what I have changed. I believe, we have some .gitignored folders in the styleguide that can cause trouble when you switch back and forth branches.

roschaefer · 2018-12-10T23:34:59Z

I merged in #84 consider to merge that PR before reviewing this PR.

@visualjerk

@visualjerk could you help us out on this PR? I'm trying to get rid of this error: ``` Unknown custom element: <ds-table> - did you register the component correctly? For recursive components, make sure to provide the "name" option. ``` How do we tell @vue/test-utils to stub globally registered components? Second, I don't understand why the resulting html() of the categories components looks so odd: ``` <h1 class="ds-heading ds-heading-h1" space="small" categories="[object Object],[object Object],[object Object],[object Object],[object Object]"> <h3 class="ds-card">   <div class="ds-card-content"> Themen / Kategorien </div> </h3> <ds-table data="" fields="icon,name,postCount" condensed=""></ds-table></h1> ``` Why on earth does the categories array end up in the `categories` property of `ds-heading` component? @visualjerk and @appinteractive have a look, please 😘

…gories

…/hc-prototype-ui into admin-tags-and-categories

roschaefer · 2018-12-12T15:59:23Z

layouts/default.vue

@@ -19,6 +19,7 @@
              style="float: right"
            >
              <a
+                class="avatar-menu"


@appinteractive do we use some sort of fancy CSS naming like BEM?

Yeah kinda, as you can see we prefix the styles with the component name. But not actually in the ugly BEM style.

@appinteractive

@appinteractive and I decided to test the page with a fullstack test. It makes more sense for pages who request data from the backend.

…gories

roschaefer

@appinteractive good to merge

appinteractive · 2018-12-12T22:53:04Z

@roschaefer the wrong backend branch is checked out! That’s why it failes.

See: https://stackoverflow.com/a/20115678

roschaefer · 2018-12-13T12:16:30Z

@appinteractive ha! The PR check fails because it's on master. How do we tackle that? 🤔

roschaefer · 2018-12-13T12:17:47Z

@appinteractive maybe we can start with a workflow to merge the backend first and then run the full stack tests again?

roschaefer · 2018-12-13T12:33:17Z

@appinteractive green! Wohoo

…@babel/node-7.2.2 Bump @babel/node from 7.2.0 to 7.2.2

appinteractive added 3 commits December 8, 2018 13:44

merged tags and categories in

Verified

This commit was signed with the committer’s verified signature. The key has expired.

kylekurz Kyle Kurz

GPG key ID: 27D16B5023628B0B
Expired

Verified
Learn about vigilant mode

c96e224

fixed linting issues

9042089

remove location related stuff

f3bf82f

appinteractive mentioned this pull request Dec 8, 2018

Admin tags and categories Human-Connection/Nitro-Backend#62

Merged

appinteractive requested a review from roschaefer December 8, 2018 13:28

appinteractive added 3 commits December 8, 2018 14:30

fixed dublicated classes

4283c4d

Merge branch 'master' into admin-tags-and-categories

8c1b1fc

Merge branch 'master' into admin-tags-and-categories

902f2d4

roschaefer suggested changes Dec 9, 2018

View reviewed changes

Merge remote-tracking branch 'origin/master' into admin-tags-and-cate…

0b01ab3

…gories

roschaefer added 4 commits December 11, 2018 00:29

Update @vue/test-utils + @vue/server-test-utils

ccb16fe

Just ignore the test for the styleguide - passing

5ed0954

Merge branch 'several_updates_on_travis_yml' into admin-tags-and-cate…

30595f4

…gories

Run component tests on Travis CI

809a250

roschaefer and others added 9 commits December 11, 2018 01:36

Merge remote-tracking branch 'origin/master' into admin-tags-and-cate…

7ecaeda

…gories

Merge branch 'admin-tags-and-categories' of github.com:appinteractive…

0aa550b

…/hc-prototype-ui into admin-tags-and-categories

Merge branch 'master' into admin-tags-and-categories

25c60d2

Clone+install backend at $TRAVIS_BRANCH in build

5b1544d

Copy cypress files back

bf9db1e

Run cypress on Travis CI

20225b6

Follow CodeFactors suggestions

c1183e6

Implement cucumber test with cypress

78931ef

roschaefer added 2 commits December 12, 2018 03:27

Green the cucumber

1316644

Fix lint

0fcff96

roschaefer reviewed Dec 12, 2018

View reviewed changes

roschaefer added 5 commits December 12, 2018 18:01

Undo the local imports

6fc2030

Implement first scenario for categories

96a30ca

All cucumbers have passed

c8f23f9

Drop the component test for the page

669ef10

@appinteractive and I decided to test the page with a fullstack test. It makes more sense for pages who request data from the backend.

Merge remote-tracking branch 'origin/master' into admin-tags-and-cate…

908e9b4

…gories

roschaefer approved these changes Dec 12, 2018

View reviewed changes

roschaefer added 2 commits December 12, 2018 22:01

Add cucumber-preprocessor to Travis build

fd7a4d8

Cucumber preprocessor must be added locally

a40fafa

Fix the clone of backend repo

4513b40

See: https://stackoverflow.com/a/20115678

Merge branch 'master' into admin-tags-and-categories

2c463fd

roschaefer merged commit 010bac5 into master Dec 13, 2018

roschaefer deleted the admin-tags-and-categories branch December 13, 2018 12:33

roschaefer pushed a commit that referenced this pull request Mar 20, 2019

Merge pull request #79 from Human-Connection/dependabot/npm_and_yarn/…

f420708

…@babel/node-7.2.2 Bump @babel/node from 7.2.0 to 7.2.2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Admin tags and categories #79

Admin tags and categories #79

appinteractive commented Dec 8, 2018 •

edited

Loading

roschaefer left a comment

appinteractive commented Dec 10, 2018

roschaefer commented Dec 10, 2018

roschaefer commented Dec 10, 2018 •

edited

Loading

appinteractive commented Dec 10, 2018

roschaefer commented Dec 10, 2018

roschaefer commented Dec 10, 2018

roschaefer commented Dec 10, 2018 •

edited

Loading

roschaefer Dec 12, 2018

appinteractive Dec 12, 2018

roschaefer left a comment

appinteractive commented Dec 12, 2018

roschaefer commented Dec 13, 2018

roschaefer commented Dec 13, 2018

roschaefer commented Dec 13, 2018

Admin tags and categories #79

Admin tags and categories #79

Conversation

appinteractive commented Dec 8, 2018 • edited Loading

roschaefer left a comment

Choose a reason for hiding this comment

appinteractive commented Dec 10, 2018

roschaefer commented Dec 10, 2018

roschaefer commented Dec 10, 2018 • edited Loading

appinteractive commented Dec 10, 2018

roschaefer commented Dec 10, 2018

roschaefer commented Dec 10, 2018

roschaefer commented Dec 10, 2018 • edited Loading

roschaefer Dec 12, 2018

Choose a reason for hiding this comment

appinteractive Dec 12, 2018

Choose a reason for hiding this comment

roschaefer left a comment

Choose a reason for hiding this comment

appinteractive commented Dec 12, 2018

roschaefer commented Dec 13, 2018

roschaefer commented Dec 13, 2018

roschaefer commented Dec 13, 2018

appinteractive commented Dec 8, 2018 •

edited

Loading

roschaefer commented Dec 10, 2018 •

edited

Loading

roschaefer commented Dec 10, 2018 •

edited

Loading