Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

37 full text search top bar #264

Merged
merged 65 commits into from
Mar 18, 2019
Merged

37 full text search top bar #264

merged 65 commits into from
Mar 18, 2019

Conversation

roschaefer
Copy link
Contributor

@roschaefer roschaefer commented Mar 18, 2019

... @mattwr18 are currently confused about the failing build server.

We created this PR to check if the error comes from different remotes.

roschaefer and others added 30 commits December 8, 2018 15:43
in `docker-compose.yml` and `docker-compose.override.yml`. This should speed
up builds e.g. on Travis CI, which does not need to sync folders or run
`yarn run dev` if the docker image was built recently. Also it should
make the build more reliable as it behaves more similar to our deployment.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
mattwr18 and others added 24 commits March 5, 2019 07:07

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
- Press enter starts search
- Press escape clears search
- Select entry goes to post
- Select dropdown content
- test the default props values
- test that is open changes when focused on or on blur
- test that the input is clearable, failing still
- clear()
- handleInput()
- onEnter()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- break focus and blur into two functions
- add failing test for onSelect function

Co-authored-by: Wolfgang Huss <wolle.huss@pjannto.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor Author

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I cannot "approve" my own PR

@@ -0,0 +1,86 @@
import gql from 'graphql-tag'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have tested the store, too

@roschaefer
Copy link
Contributor Author

@mattwr18 can you approve this?

Copy link
Member

@mattwr18 mattwr18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @appinteractive, @Tirokk, @roschaefer for getting this across the finish line! really excited to have been a part of this feature

@roschaefer roschaefer merged commit 0c2a228 into master Mar 18, 2019
@pr-triage pr-triage bot added the PR: merged label Mar 18, 2019
@roschaefer roschaefer deleted the 37-full-text-search-top-bar branch March 18, 2019 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants