This repository was archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
+724
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `docker-compose.yml` and `docker-compose.override.yml`. This should speed up builds e.g. on Travis CI, which does not need to sync folders or run `yarn run dev` if the docker image was built recently. Also it should make the build more reliable as it behaves more similar to our deployment.
…7-full-text-search-top-bar
…-Web into 37-full-text-search-top-bar
- Press enter starts search - Press escape clears search - Select entry goes to post - Select dropdown content
- test the default props values - test that is open changes when focused on or on blur - test that the input is clearable, failing still
…7-full-text-search-top-bar
…7-full-text-search-top-bar
- clear() - handleInput() - onEnter()
…7-full-text-search-top-bar
- break focus and blur into two functions - add failing test for onSelect function Co-authored-by: Wolfgang Huss <wolle.huss@pjannto.com>
…-Web into 37-full-text-search-top-bar
…7-full-text-search-top-bar
roschaefer
commented
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, I cannot "approve" my own PR
@@ -0,0 +1,86 @@ | |||
import gql from 'graphql-tag' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have tested the store, too
@mattwr18 can you approve this? |
mattwr18
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job @appinteractive, @Tirokk, @roschaefer for getting this across the finish line! really excited to have been a part of this feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... @mattwr18 are currently confused about the failing build server.
We created this PR to check if the error comes from different remotes.