Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Report Content #107

Merged
merged 65 commits into from
Jan 22, 2019
Merged

Report Content #107

merged 65 commits into from
Jan 22, 2019

Conversation

appinteractive
Copy link
Member

@appinteractive appinteractive commented Dec 29, 2018

Implement basic content reporting

As a User
I would like to click on the button
to report inappropriate content

Todos

  • Write Integration Tests

UI

bildschirmfoto 2019-01-11 um 17 38 31

bildschirmfoto 2019-01-11 um 17 38 37

bildschirmfoto 2019-01-11 um 19 19 47

Dependencies

Relates to Human-Connection/Nitro-Backend#99
Close #70

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
@appinteractive appinteractive changed the title [WIP] Report content [WIP] Report Content Button Dec 29, 2018
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to create at least one cucumber test here (to document the behaviour) and many components tests if possible.

icon: 'flag'
}
]
// if (this.isAdmin) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No disabled code please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess why it’s WIP? 🤔😆

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
…ke in Portal 1 & 2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
…e styleguide

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
@appinteractive appinteractive added the feature New feature or request label Jan 12, 2019
@appinteractive appinteractive changed the title [WIP] Report Content Button [WIP] Report Content Jan 12, 2019

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
@appinteractive
Copy link
Member Author

@roschaefer could you already take a look at the cucumber tests?

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
@appinteractive appinteractive added this to the Bacchus milestone Jan 18, 2019

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some requests for the cucumber scenario

So I can look into it and decide what to do

Scenario: Report a Post from landingpage
Given I am logged in as "user"
Copy link
Contributor

@roschaefer roschaefer Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given I am logged in as "user"
Given I am an ordinary user with no further permissions

Given I am logged in as "user"
And I am on the "landing" page

When I click on a Post menu and select the report option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When I click on a Post menu and select the report option
When I click the "report" button in the context menu of a post

And I am on the "landing" page

When I click on a Post menu and select the report option
And I click on send in the confirmation dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And I click on send in the confirmation dialog
And I confirm the question "Do you really want to report this post?"


Scenario: See reported content
Given I am logged in as "moderator"
And I previously reported a post
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And I previously reported a post
And another user previously reported a post

And I previously reported a post

When I am on the "moderation" page
Then I see my reported post
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then I see my reported post
Then I see the reported post

Then I see my reported post

Scenario: Report while reading Post
Given I am logged in as "admin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given I am logged in as "admin"
Given I am logged in as an ordinary user without privileges

I would take the user with the lowest authorization.


When I report the current post
And I visit the "moderation" page
Then I see my reported post
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then I see my reported post
Then all the reported content is there

This communicates that all reported content is in one central location

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
@datenbrei datenbrei modified the milestones: Bacchus, Chronos Jan 21, 2019
appinteractive and others added 5 commits January 21, 2019 11:49

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec

Verified

This commit was signed with the committer’s verified signature. The key has expired.
appinteractive Grzegorz Leoniec
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appinteractive appinteractive changed the title [WIP] Report Content Report Content Jan 22, 2019
@appinteractive appinteractive merged commit e219cf8 into master Jan 22, 2019
@appinteractive appinteractive deleted the report-content branch January 22, 2019 13:53
roschaefer pushed a commit that referenced this pull request Mar 20, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…/neo4j-graphql-js-2.2.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants