This repository was archived by the owner on Mar 22, 2019. It is now read-only.
Disable posts #207
Merged
Disable posts #207
+445
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
commented
Mar 5, 2019
roschaefer
requested review from
appinteractive
and removed request for
appinteractive
|
@roschaefer it looks good! was just having a look at the tests and reading the comments here... it looks like it was more work than we were anticipating? |
Tirokk
approved these changes
Mar 7, 2019
|
🥳 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a horribly complicated implementation to allow only moderators to disable posts (only posts).
Reasons why this is so bad:
disabled: trueif disabled is a derived property