This repository was archived by the owner on Mar 22, 2019. It is now read-only.
[WIP] Editor #136
Merged
[WIP] Editor #136
+691
−789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Separating the relations from mere properties removes boilerplate code.
Only change the password, if we are the default user. Everything else should be executed.
I put the relevant line on categories and organizations too, but I didn't test it separately. I could have tested it but found it unnecessary repeating
I found a way to cleanly request additional attributes in our middleware. We can use this pattern if we e.g. require the author of posts and comments to check if the user is the author and therefore authorized to update or delete the post. CC @mattwr18 @appinteractive @Tirokk
@appinteractive can we merge this soon?
Refactor seeds and tests
roschaefer
reviewed
Feb 22, 2019
src/seed/seed-db.js
Outdated
| create('user', { id: 'u3', name: 'Jenny Rostock', role: 'user', email: 'user@example.org' }), | ||
| create('user', { id: 'u4', name: 'Tick', role: 'user', email: 'tick@example.org' }), | ||
| create('user', { id: 'u5', name: 'Trick', role: 'user', email: 'trick@example.org' }), | ||
| create('user', { id: 'u6', name: 'Track', role: 'user', email: 'track@example.org' }), |
There was a problem hiding this comment.
We have to rename the users. I accidently used the German versions of Dagobert Ducks grandchildren here. But the English version is different, see here: https://en.wikipedia.org/wiki/Huey,_Dewey,_and_Louie
The idMiddleware was adding selection fields to the resolveInfo even if
the selection fields were empty. This caused a bug for each resolve
function including
```
{
isLoggedin
}
```
which does not have any additional curly braces after the query.
Ids are queried only for well known queries and mutations
This is necessary for fullstack testing in the frontend repository
* use the same `relate` method for now * use a capital letter for the model `user` instead of `User`
We have to specify the `yarn run test:cypress` in `.travis.yml` in the Nitro-Web repo.
|
@appinteractive CodeFactor behaves awkwardly. I ignored the issue on the last build, now the check fails again. Can we disable CodeFactor @appinteractive ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved content xss, sanitization, formatting and contentExcerpt updates
Related with Human-Connection/Nitro-Web#153