New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callback API into Rules #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, it looks great! I left a few comments for things I'd like to change.
Could you also add a few unit tests please?
Thank you for review!
I have a question: Scanner callback API make similar Rule callback API or set callback into Scanner, like this: let rules = Rules...;
let scanner = rules.scanner();
scanner.set_callback(...);
scanner.set_timeout(...); ? |
ca559d7
to
360183a
Compare
I'm not sure. I think I prefer to keep it as the Rule API, it might be more convenient to use closures. |
@Hugal31, I add Scanner callback API |
f448951
to
1b52d34
Compare
3ea32c4
to
4f81413
Compare
@Hugal31 rebase master. Can you make release? I need this changes in project |
v0.8.0 released! |
Hello @Hugal31 , sorry for my english, I will try to describe what I want to do.
If this PR is Ok, I can write Callback API for Scanner