fix: unit test scanner_scan_proc utf-16 encoding #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aaaand the test still fails, so seems it's not a timeout problem ... I really don't get it, and I can't manage to reproduce it on my windows VM. Do you encounter it on any of your machines ? |
|
I don't usually code on Windows, so I've never tried to reproduced it. |
|
Maybe this is an encoding problem with the needle string ? (Yes I'm desperate at this point) |
Orycterope
force-pushed
the
scan_proc_test_tiemout
branch
from
a34b15a
to
bc62faf
Compare
Orycterope
changed the title
|
So this was an encoding problem ! On windows, the string is present in cmd's memory, but only in utf-16 format. I've updated the test case to look only for The test worked in my windows VM because somehow the string must have been also present in utf-8 form. I've kept the longer timeout, cause we never know |
|
Good catch! Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #25 by extending the timeout. Let's see if it works.