Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: vendored feature uses v4.1.1 #29

Merged
merged 1 commit into from May 26, 2021
Merged

Conversation

Orycterope
Copy link
Contributor

Yara just released v4.1.1, which is just a bugfix release containing a fix i'm interested in.

This PR simply bumps the submodule to the newest version, and updates the travis jobs to manually build this version too.

I haven't updated the bundled bindings files, since this is just a bugfix release and there's no change to the api (or at least I hope so, and travis will confirm it).

@Hugal31
Copy link
Owner

Hugal31 commented May 25, 2021

Thanks for your PR.

There is just on thing that bother me: you included the patch version number in the feature flag name on purpose, in #22, because you said "because yara does not use semantic versioning, and patch updates sometimes still break compatibility". So we should update the bundled headers anyway.

@Orycterope
Copy link
Contributor Author

You're right. Since the bindings are completely identical, i've just renamed the files, and I've updated the name of the feature to bundled-4_1_1

@Hugal31 Hugal31 merged commit dcb67a8 into Hugal31:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants