show cc compilation wanings #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM I hope your PR on libyara will be merged soon! Do you think we should include a mention of this UB at least in the README? Or maybe add a runtime warning or a quickfix before your PR is merged? |
|
Thank you. The PR to libyara is already merged, but not yet released. Regarding the mention to this UB, this PR is precisely here to display the warning when compiling for windows, so we should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just lost a week debugging an optimized undefined behaviour in libyara which was clearly hinted by clang, but the warnings were suppressed in the build.rs.
This PR re-enables all warnings, except for a few harmless warning families to avoid spam during compilation.
I've tried to review all the warnings we get on x86, x64, linux, windows, with both clang and cl, and disable all warning families that are clearly harmless for us. The only one that concerns me is
-Wsign-compare, but it also is the more frequent by far, so I've also disabled it.