Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scanner::test::scanner_scan_proc fails randomly on Windows #25

Closed
Hugal31 opened this issue Apr 29, 2021 · 3 comments · Fixed by #30
Closed

scanner::test::scanner_scan_proc fails randomly on Windows #25

Hugal31 opened this issue Apr 29, 2021 · 3 comments · Fixed by #30

Comments

@Hugal31
Copy link
Owner

Hugal31 commented Apr 29, 2021 •
edited

This can be see in some Travis jobs: sometimes, the test scanner::test::scanner_scan_proc fails on Windows.
@Hugal31
Copy link
Owner Author

Hugal31 commented May 6, 2021

@Orycterope, since you introduce those tests, do you have an idea?
Maybe the process exit too early?
An other way to do it would be to make the process wait for a signal instead of sleeping / pinging for a few seconds.

@Orycterope
Copy link
Contributor

I'm gonna look into it !

@Orycterope
Copy link
Contributor

I can't manage to reproduce it outside of travis. I'm going to also bet on the exit too early, and hope for the best.

Orycterope added a commit to Orycterope/yara-rust that referenced this issue May 25, 2021
@Orycterope
fix: unit test scanner_scan_proc longer timeout
2f1f5ec 
fixes Hugal31#25
@Orycterope Orycterope mentioned this issue May 25, 2021
Merged
Orycterope added a commit to Orycterope/yara-rust that referenced this issue May 28, 2021
@Orycterope
fix: unit test scanner_scan_proc encoding
bc62faf 
fixes Hugal31#25
@Hugal31 Hugal31 mentioned this issue Jun 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unit test scanner_scan_proc utf-16 encoding Orycterope/yara-rust
2 participants
@Orycterope @Hugal31