Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch error stack traces are missing in Node #65

Open
RobertWHurst opened this issue Jun 20, 2017 · 1 comment
Open

Fetch error stack traces are missing in Node #65

RobertWHurst opened this issue Jun 20, 2017 · 1 comment

Comments

@RobertWHurst
Copy link

RobertWHurst commented Jun 20, 2017

It seems isomorphic-fetch is using an old version of node-fetch that doesn't render stack traces correctly for their custom fetch error class. I've made a PR to resolve the issue. I suggest either updating isomorphic-fetch if and when the author merges the PR, or relying directly on node-fetch and whatwg-fetch instead.

Example of a stack trace from an ECONNREFUSED error:
screen shot 2017-06-20 at 1 24 02 pm

@ndelvalle
Copy link
Member

ndelvalle commented Jun 20, 2017

Thanks @RobertWHurst I just subscribed to the PR to see if it gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants