Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-credential-helpers: pass variant #39517

Closed
glensc opened this issue May 4, 2019 · 7 comments
Closed

docker-credential-helpers: pass variant #39517

glensc opened this issue May 4, 2019 · 7 comments
Labels
outdated PR was locked due to age

Comments

@glensc
Copy link
Contributor

glensc commented May 4, 2019

so, docker/docker-credential-helpers has also pass variant.

how to package this? to existing formula?

  1. https://github.com/Homebrew/homebrew-core/blob/9b37cb405386ed11af4cb68130d56ceb5335d413/Formula/docker-credential-helper.rb
  2. create new formula: docker-credential-helper-pass?

as would be accurate to also install the pass dependency that pass requires...

@glensc
Copy link
Contributor Author

glensc commented May 4, 2019

i think separate formula is way to go, because also need to link and overwrite if installing docker-for-mac. and without link doesn't get any program from the formula, not just conflicting ones

...
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/docker-credential-osxkeychain
Target /usr/local/bin/docker-credential-osxkeychain
already exists. You may want to remove it:
  rm '/usr/local/bin/docker-credential-osxkeychain'

To force the link and overwrite all conflicting files:
  brew link --overwrite docker-credential-helper

To list all files that would be deleted:
  brew link --overwrite --dry-run docker-credential-helper

Possible conflicting files are:
/usr/local/bin/docker-credential-osxkeychain -> /Applications/Docker.app/Contents/Resources/bin/docker-credential-osxkeychain
==> Summary

@zbeekman
Copy link
Contributor

zbeekman commented May 15, 2019

@glensc: Can docker-crednetial-helper be built against both osx-keychain and pass at the same time? Or does it require a different formula?

Also, I saw your issue on their repo that they do not currently support using pass on macOS. If they don't support using pass on macOS, then I'm going to close this as "won't fix" and we can revisit it once docker-credential-helpers supports pass on macOS.

@zbeekman zbeekman added the needs response Needs a response from the issue/PR author label May 15, 2019
@glensc
Copy link
Contributor Author

glensc commented May 16, 2019

@zbeekman yes, it can be built two variants from same formula. and to make build need to copy (or rename) two files:

however, I think it should be separate formula due to usability issues:

@no-response no-response bot removed the needs response Needs a response from the issue/PR author label May 16, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

4 participants
@glensc @zbeekman @fxcoudert and others