Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ecstatic not used anymore? #285

Closed
JotaroS opened this issue Apr 23, 2020 · 5 comments
Closed

Is ecstatic not used anymore? #285

JotaroS opened this issue Apr 23, 2020 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@JotaroS
Copy link
Collaborator

JotaroS commented Apr 23, 2020

"ecstatic": "^3.3.1",

Ecstatic is deprecated and there's security vulnerability against DoS attack.

I see this isn't refered by any code but still has to be imported?

(Last commit wrt this has been made by @lukaswagner https://github.com/HassoPlattnerInstituteHCI/dualpantoframework/blame/f3968089c393f84c25a923c5d52f744afc8b0694/package.json#L32)

@JotaroS JotaroS added the question Further information is requested label Apr 23, 2020
@lukaswagner
Copy link
Collaborator

This was included to fix a problem with http-server 0.11.1 including a broken version of ecstatic (3.0.0). It seems the new http-server version 0.12.1 uses ecstatic 3.3.2, so you should be able to update http-server and drop the ecstatic entry in our package.json.

@lukaswagner
Copy link
Collaborator

Regarding the vulnerability in ecstatic, it seems to be fixed in v3.3.2:

Patches for the security vulnerability have been applied to versions v4.1.2, v3.3.2 and v2.2.2. Older versions will remain unpatched. I apologize for the inconvenience.
(jfhbrook/node-ecstatic#259)

@JotaroS
Copy link
Collaborator Author

JotaroS commented Apr 23, 2020

Thanks @lukaswagner !

JotaroS added a commit that referenced this issue Jun 7, 2020
#285 removed ecstatic / updated http-server
teseted plotter.js and worked fine.
@boeckhoff
Copy link
Collaborator

@JotaroS so this is fixed ? if so please close

@JotaroS
Copy link
Collaborator Author

JotaroS commented Jul 9, 2020

Screen Shot 2020-07-09 at 16 55 45

@JotaroS JotaroS closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants