Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Support solidity ^0.8.0? #540

Open
clemsos opened this issue Oct 12, 2021 · 2 comments · May be fixed by #541
Open

Support solidity ^0.8.0? #540

clemsos opened this issue Oct 12, 2021 · 2 comments · May be fixed by #541

Comments

@clemsos
Copy link

clemsos commented Oct 12, 2021

Hello, I am trying to import some libs from a newer version of solidity. Do you have any plans to upgrade to sol v8?
Thanks !
@HardlyDifficult
Copy link
Owner

Hey, I have not started looking into that - but would be interested in upgrading at some point. If anyone else had time to make the changes I'd be happy to look them over. I'm not sure when I will find time to do it myself.

@clemsos clemsos linked a pull request Oct 14, 2021 that will close this issue
Draft
@clemsos
Copy link
Author

clemsos commented Oct 14, 2021

I have started a PR but @uniswap/lib contains some expressions that breaks after the solc version bump.

In particular, replace usages of uint(-1) with type(uint).max.

from New restrictions in 0.8.0

Looking at it, it seems like @uniswap/lib is deprec. It could be replaced by contracts from Uniswap/v2-core but I see the pragmas there are also in the ^0.5.x range so it may not make things easier either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Solidity 0.8.x clemsos/hardlydifficult-eth
2 participants
@clemsos @HardlyDifficult