Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance #1206

Open
4 of 5 tasks
kennytv opened this issue Apr 28, 2023 · 2 comments
Open
4 of 5 tasks

Performance #1206

kennytv opened this issue Apr 28, 2023 · 2 comments
Labels
2. backend This issue/pr relates to an issue/change on the backend 2. frontend This issue/pr relates to an issue/change on the frontend help wanted Extra attention is needed

Comments

@kennytv
Copy link
Member

kennytv commented Apr 28, 2023 •
edited

Areas of code that are in dire need of performance improvements:

  • Opening https://hangar.papermc.io/ViaVersion/ViaVersion makes 3 blocking calls to first get the user, then the org, then the project (plus additional permission calls). These should be parallelized or moved together
  • The route permission call should be done non-blocking/moved to the specific subroutes like user and project, so they can be done in parallel
  • Database queries in the backend are often split into a lot of small steps and should be combined/optimized, especially getting project data and versions of a project
  • Table indexes!
  • Fix Spring caches
@kennytv kennytv added help wanted Extra attention is needed 2. frontend This issue/pr relates to an issue/change on the frontend 2. backend This issue/pr relates to an issue/change on the backend labels Apr 28, 2023
MiniDigger added a commit that referenced this issue Apr 29, 2023
@MiniDigger
feat: only block on user call when actually displaying the user site
cc3730e 
this allows the user and project requests to run concurrently, addressing part of #1206
MiniDigger added a commit that referenced this issue Apr 29, 2023
@MiniDigger
perf: dont block on route perms (#1206)
0f1a151
@MiniDigger
Copy link
Member

we should fetch version dependencies concurrently
https://i.imgur.com/OJFJtsJ.png

@MiniDigger
Copy link
Member

#1225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. backend This issue/pr relates to an issue/change on the backend 2. frontend This issue/pr relates to an issue/change on the frontend help wanted Extra attention is needed
Projects
Hangar Roadmap
Status: New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MiniDigger @kennytv