Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Add QA checks to ensure code quality #623

Open
pandafy opened this issue Oct 5, 2020 · 4 comments
Open

Add QA checks to ensure code quality #623

pandafy opened this issue Oct 5, 2020 · 4 comments
Labels
feature-request Unaccepted user submitted new feature suggestion

Comments

@pandafy
Copy link
Contributor

pandafy commented Oct 5, 2020

Feature description

While working on #617 I encountered that some files have trailing white spaces. I have configured my code editor to automatically trim while spaces. Since white spaces can be added by anyone and could sneak through reviews, I recommend adding QA checks to make sure they are absent and does not affect code quality.

@pandafy pandafy added the feature-request Unaccepted user submitted new feature suggestion label Oct 5, 2020
@MattIPv4
Copy link
Member

MattIPv4 commented Oct 5, 2020

+1 to this, we should be linting html/css

@naomi-lgbt
Copy link

Ooooh can I poke at this? I'm addicted to GitHub actions 😅

@MattIPv4
Copy link
Member

MattIPv4 commented Oct 7, 2020

I'm not sure what the best practice is, but I imagine rubocop can lint .html.erb files directly, and then yeah, we'll need a new job (& docs) for running sass-lint or w/e

@MattIPv4
Copy link
Member

MattIPv4 commented Oct 7, 2020

But yes, go for it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Unaccepted user submitted new feature suggestion
Projects
None yet
Development

No branches or pull requests

3 participants