forked from dotnet/roslynator
/
InvalidArgumentNullCheckAnalyzer.cs
138 lines (109 loc) · 4.59 KB
/
InvalidArgumentNullCheckAnalyzer.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
// Copyright (c) Josef Pihrt and Contributors. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System.Collections.Immutable;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
namespace Roslynator.CSharp.Analysis;
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public sealed class InvalidArgumentNullCheckAnalyzer : BaseDiagnosticAnalyzer
{
private static ImmutableArray<DiagnosticDescriptor> _supportedDiagnostics;
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
{
get
{
if (_supportedDiagnostics.IsDefault)
Immutable.InterlockedInitialize(ref _supportedDiagnostics, DiagnosticRules.InvalidArgumentNullCheck);
return _supportedDiagnostics;
}
}
public override void Initialize(AnalysisContext context)
{
base.Initialize(context);
context.RegisterSyntaxNodeAction(f => AnalyzeMethodDeclaration(f), SyntaxKind.MethodDeclaration);
context.RegisterSyntaxNodeAction(f => AnalyzeConstructorDeclaration(f), SyntaxKind.ConstructorDeclaration);
}
private static void AnalyzeMethodDeclaration(SyntaxNodeAnalysisContext context)
{
var methodDeclaration = (MethodDeclarationSyntax)context.Node;
AnalyzeParameterList(context, methodDeclaration.ParameterList, methodDeclaration.Body);
}
private static void AnalyzeConstructorDeclaration(SyntaxNodeAnalysisContext context)
{
var constructorDeclaration = (ConstructorDeclarationSyntax)context.Node;
AnalyzeParameterList(context, constructorDeclaration.ParameterList, constructorDeclaration.Body);
}
private static void AnalyzeParameterList(SyntaxNodeAnalysisContext context, ParameterListSyntax parameterList, BlockSyntax body)
{
if (body is null)
return;
if (parameterList is null)
return;
SeparatedSyntaxList<ParameterSyntax> parameters = parameterList.Parameters;
if (!parameters.Any())
return;
SyntaxList<StatementSyntax> statements = body.Statements;
int statementCount = statements.Count;
if (statementCount == 0)
return;
int lastIndex = -1;
foreach (ParameterSyntax parameter in parameters)
{
if (parameter.IsParams())
break;
lastIndex++;
}
if (lastIndex == -1)
return;
foreach (StatementSyntax statement in statements)
{
ArgumentNullCheckAnalysis nullCheck = ArgumentNullCheckAnalysis.Create(statement, context.SemanticModel, context.CancellationToken);
if (nullCheck.Success)
{
ParameterSyntax parameter = FindParameter(nullCheck.Name);
if (parameter is not null)
{
if (parameter.Default?.Value.IsKind(
SyntaxKind.NullLiteralExpression,
SyntaxKind.DefaultLiteralExpression,
SyntaxKind.DefaultExpression) == true
|| IsNullableReferenceType(context, parameter))
{
if (statement is IfStatementSyntax ifStatement)
{
context.ReportDiagnostic(DiagnosticRules.InvalidArgumentNullCheck, ifStatement.IfKeyword);
}
else
{
context.ReportDiagnostic(DiagnosticRules.InvalidArgumentNullCheck, statement);
}
}
}
}
}
bool IsNullableReferenceType(SyntaxNodeAnalysisContext context, ParameterSyntax parameter)
{
TypeSyntax type = parameter.Type;
if (type.IsKind(SyntaxKind.NullableType))
{
ITypeSymbol typeSymbol = context.SemanticModel.GetTypeSymbol(type, context.CancellationToken);
if (typeSymbol?.IsKind(SymbolKind.ErrorType) == false
&& typeSymbol.IsReferenceType)
{
return true;
}
}
return false;
}
ParameterSyntax FindParameter(string name)
{
for (int i = 0; i <= lastIndex; i++)
{
if (parameters[i].Identifier.ValueText == name)
return parameters[i];
}
return null;
}
}
}